[webkit-reviews] review granted: [Bug 178735] Add support for unregistering a service worker : [Attachment 324708] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 25 11:23:57 PDT 2017


Brady Eidson <beidson at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 178735: Add support for unregistering a service worker
https://bugs.webkit.org/show_bug.cgi?id=178735

Attachment 324708: Patch

https://bugs.webkit.org/attachment.cgi?id=324708&action=review




--- Comment #3 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 324708
  --> https://bugs.webkit.org/attachment.cgi?id=324708
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324708&action=review

> Source/WebCore/workers/service/server/SWServerRegistration.cpp:181
> +    // If the origin of jobâs scope url is not jobâs client's origin, then:

Get rid of some unicode stuff (check-webkit-style used to catch these things)


More information about the webkit-reviews mailing list