[webkit-reviews] review granted: [Bug 178000] [WinCairo] Add WebKit platform files for wincairo webkit : [Attachment 323678] [PATCH] WebKit platform files for wincairo webkit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 25 11:13:40 PDT 2017


Alex Christensen <achristensen at apple.com> has granted Yousuke Kimoto
<Yousuke.Kimoto at sony.com>'s request for review:
Bug 178000: [WinCairo] Add WebKit platform files for wincairo webkit
https://bugs.webkit.org/show_bug.cgi?id=178000

Attachment 323678: [PATCH] WebKit platform files for wincairo webkit

https://bugs.webkit.org/attachment.cgi?id=323678&action=review




--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 323678
  --> https://bugs.webkit.org/attachment.cgi?id=323678
[PATCH] WebKit platform files for wincairo webkit

View in context: https://bugs.webkit.org/attachment.cgi?id=323678&action=review

> Source/WebKit/Platform/win/LoggingWin.cpp:50
> +    return String(buffer.get());

Is buffer null-terminated?  Could we use length here?


More information about the webkit-reviews mailing list