[webkit-reviews] review granted: [Bug 178673] Enable ServiceWorker to fetch resources : [Attachment 324754] Fixing didFinish/didFail

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 25 09:57:43 PDT 2017


Brady Eidson <beidson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 178673: Enable ServiceWorker to fetch resources
https://bugs.webkit.org/show_bug.cgi?id=178673

Attachment 324754: Fixing didFinish/didFail

https://bugs.webkit.org/attachment.cgi?id=324754&action=review




--- Comment #19 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 324754
  --> https://bugs.webkit.org/attachment.cgi?id=324754
Fixing didFinish/didFail

View in context: https://bugs.webkit.org/attachment.cgi?id=324754&action=review

Make Windows build.

> Source/WebKit/WebProcess/Storage/ServiceWorkerContextManager.cpp:75
> +    }
> +    PAL::SessionID sessionID() const final { return m_sessionID; }

Empty line between these

> Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:207
> +    ASSERT_NOT_REACHED();

RELEASE_*

> Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:219
> +    ASSERT_NOT_REACHED();
> +    return 0;
> +}
> +
> +PAL::SessionID WebFrameLoaderClient::sessionID() const
> +{
> +    ASSERT_NOT_REACHED();

Ditto


More information about the webkit-reviews mailing list