[webkit-reviews] review granted: [Bug 178764] Make SharedStringHashTable less error prone : [Attachment 324774] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 25 09:32:46 PDT 2017


youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 178764: Make SharedStringHashTable less error prone
https://bugs.webkit.org/show_bug.cgi?id=178764

Attachment 324774: Patch

https://bugs.webkit.org/attachment.cgi?id=324774&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 324774
  --> https://bugs.webkit.org/attachment.cgi?id=324774
Patch

LGTM.
Usually classes are split in their own files. Maybe this should be done here as
well.
That way, some files would only include the ReadOnly version.


More information about the webkit-reviews mailing list