[webkit-reviews] review granted: [Bug 178488] Web Inspector: Styles Redesign: Newly added invalid property isn't immediately shown as invalid : [Attachment 324620] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 25 09:06:42 PDT 2017


Brian Burg <bburg at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 178488: Web Inspector: Styles Redesign: Newly added invalid property isn't
immediately shown as invalid
https://bugs.webkit.org/show_bug.cgi?id=178488

Attachment 324620: Patch

https://bugs.webkit.org/attachment.cgi?id=324620&action=review




--- Comment #5 from Brian Burg <bburg at apple.com> ---
Comment on attachment 324620
  --> https://bugs.webkit.org/attachment.cgi?id=324620
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324620&action=review

r=me

> Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js:367
> +	   let index = insertAfterIndex + 1;

Nit: propertyIndex

> Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js:371
> +	   const dontFireEvents = true;

Nit: suppressEvents or suppressEventDispatch

> Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:-128
> -	   this._element.classList.add(...classNames);

I'd keep this as-is, unless there is some reason not to.


More information about the webkit-reviews mailing list