[webkit-reviews] review denied: [Bug 178045] Web Inspector: replace TypeVerifier with subclasses of WI.Collection : [Attachment 324803] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 25 08:46:51 PDT 2017


Brian Burg <bburg at apple.com> has denied Devin Rousso <webkit at devinrousso.com>'s
request for review:
Bug 178045: Web Inspector: replace TypeVerifier with subclasses of
WI.Collection
https://bugs.webkit.org/show_bug.cgi?id=178045

Attachment 324803: Patch

https://bugs.webkit.org/attachment.cgi?id=324803&action=review




--- Comment #6 from Brian Burg <bburg at apple.com> ---
Comment on attachment 324803
  --> https://bugs.webkit.org/attachment.cgi?id=324803
Patch

This is better, but it still seems more complicated than necessary. If you are
going to go all the way to subclassing, then each subclass should override
objectHasRequiredType(o) rather than passing in a predicate function to the
constructor. I don't see any reason why the predicate needs to be dynamically
bound at construction time since it never seems to vary for a particular
subclass.


More information about the webkit-reviews mailing list