[webkit-reviews] review denied: [Bug 160234] Check if NSURLAuthenticationChallengeSender has implemented optional methods before calling them : [Attachment 324749] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 24 23:52:24 PDT 2017


Alexey Proskuryakov <ap at webkit.org> has denied Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 160234: Check if NSURLAuthenticationChallengeSender has implemented
optional methods before calling them
https://bugs.webkit.org/show_bug.cgi?id=160234

Attachment 324749: Patch

https://bugs.webkit.org/attachment.cgi?id=324749&action=review




--- Comment #28 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 324749
  --> https://bugs.webkit.org/attachment.cgi?id=324749
Patch

>From previous discussions with Alex, I thought that we had a different plan of
attack, what changed?

In particular, it's not only wrong to call these methods, it's wrong to call
any methods on the sender object.


More information about the webkit-reviews mailing list