[webkit-reviews] review granted: [Bug 178759] Test fast/writing-mode/english-bt-text-with-spelling-marker.html should wait for editing commands to complete : [Attachment 324747] Layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 24 16:25:44 PDT 2017


Ryosuke Niwa <rniwa at webkit.org> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 178759: Test fast/writing-mode/english-bt-text-with-spelling-marker.html
should wait for editing commands to complete
https://bugs.webkit.org/show_bug.cgi?id=178759

Attachment 324747: Layout test

https://bugs.webkit.org/attachment.cgi?id=324747&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 324747
  --> https://bugs.webkit.org/attachment.cgi?id=324747
Layout test

View in context: https://bugs.webkit.org/attachment.cgi?id=324747&action=review

> LayoutTests/ChangeLog:9
> +	   character is typed before proceeding to type the next character.

Should mention that we're inserting a delay instead of saying they're typed.

>
LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker-expected.htm
l:32
> +    for (var c of text)

Use const?

> LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker.html:36
> +    for (var c of text)

Ditto.


More information about the webkit-reviews mailing list