[webkit-reviews] review granted: [Bug 178404] Web Inspector: [PARITY] Styles Redesign: Add color gradient, bezier curve, and spring inline widgets : [Attachment 324506] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 24 14:43:24 PDT 2017
Devin Rousso <webkit at devinrousso.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 178404: Web Inspector: [PARITY] Styles Redesign: Add color gradient, bezier
curve, and spring inline widgets
https://bugs.webkit.org/show_bug.cgi?id=178404
Attachment 324506: Patch
https://bugs.webkit.org/attachment.cgi?id=324506&action=review
--- Comment #11 from Devin Rousso <webkit at devinrousso.com> ---
Comment on attachment 324506
--> https://bugs.webkit.org/attachment.cgi?id=324506
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=324506&action=review
r=me
> Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:339
> + newTokens.push(...tokens);
It seems incorrect to push all of the tokens to newTokens, as we are already
using some of them in the next else-if (343). Should we instead be using
`rawTokens`?
newTokens.push(...rawTokens);
> Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:358
> newTokens.push(...tokens);
Ditto (339).
> Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:425
> + newTokens.push(...tokens);
Ditto (339).
More information about the webkit-reviews
mailing list