[webkit-reviews] review granted: [Bug 177920] Autoplay muted videos still stop playback of other streaming apps in the background : [Attachment 324712] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 24 13:38:11 PDT 2017


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 177920: Autoplay muted videos still stop playback of other streaming apps
in the background
https://bugs.webkit.org/show_bug.cgi?id=177920

Attachment 324712: Patch

https://bugs.webkit.org/attachment.cgi?id=324712&action=review




--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 324712
  --> https://bugs.webkit.org/attachment.cgi?id=324712
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324712&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:489
> +void
HTMLMediaElement::setMediaSession(std::unique_ptr<MediaElementSession>&&
mediaSession)

Why do some of the initialization in the constructor and some here? Why not
call this something like "finishSetup" and move everything from the constructor
here.

Alternatively, instead of requiring the derived classes to create and pass a
media session, you can call this "createMediaSession" and allocate the session
here.


More information about the webkit-reviews mailing list