[webkit-reviews] review granted: [Bug 177745] [Linux] Enable Gigacage in x64 Linux environment : [Attachment 324694] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 24 12:07:31 PDT 2017


Yusuke Suzuki <utatane.tea at gmail.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 177745: [Linux] Enable Gigacage in x64 Linux environment
https://bugs.webkit.org/show_bug.cgi?id=177745

Attachment 324694: Patch

https://bugs.webkit.org/attachment.cgi?id=324694&action=review




--- Comment #19 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 324694
  --> https://bugs.webkit.org/attachment.cgi?id=324694
Patch

r=me. I don't like adding BOS(LINUX) much, but madvise is inherently platform
dependent. And here, madvice needs to be called twice.
So if we can consolidate these virtual memory operation difference in each
platform into VMAllocate.h, I think it's OK.


More information about the webkit-reviews mailing list