[webkit-reviews] review granted: [Bug 178308] [JSC] modules can be visited more than once when resolving bindings through "star" exports as long as the exportName is different each time : [Attachment 323872] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 24 09:57:45 PDT 2017


Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 178308: [JSC] modules can be visited more than once when resolving bindings
through "star" exports as long as the exportName is different each time
https://bugs.webkit.org/show_bug.cgi?id=178308

Attachment 323872: Patch

https://bugs.webkit.org/attachment.cgi?id=323872&action=review




--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 323872
  --> https://bugs.webkit.org/attachment.cgi?id=323872
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323872&action=review

r=me

> Source/JavaScriptCore/ChangeLog:8
> +	   With the change of the spec[1], we now do not need to remember star
resoluted modules.

I would say "resolved" instead of "resoluted".


More information about the webkit-reviews mailing list