[webkit-reviews] review granted: [Bug 178648] [JSC] Drop ArityCheckData : [Attachment 324532] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 178648: [JSC] Drop ArityCheckData
https://bugs.webkit.org/show_bug.cgi?id=178648

Attachment 324532: Patch

https://bugs.webkit.org/attachment.cgi?id=324532&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 324532
  --> https://bugs.webkit.org/attachment.cgi?id=324532
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324532&action=review

r=me

> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:582
> +    move r1, t1

nit: would be nice to add a comment # r1 contains slotsToAdd.

> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:517
> +    move r1, t1

ditto for adding a comment about r1.