[webkit-reviews] review denied: [Bug 178713] [iOS] MediaPlayer::isAvailable() takes ~150 ms during web process initialization : [Attachment 324651] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 24 08:51:17 PDT 2017


Eric Carlson <eric.carlson at apple.com> has denied Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 178713: [iOS] MediaPlayer::isAvailable() takes ~150 ms during web process
initialization
https://bugs.webkit.org/show_bug.cgi?id=178713

Attachment 324651: Patch

https://bugs.webkit.org/attachment.cgi?id=324651&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 324651
  --> https://bugs.webkit.org/attachment.cgi?id=324651
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324651&action=review

> Source/WebCore/platform/graphics/MediaPlayer.cpp:961
> +#if USE(AVFOUNDATION)
> +    if (DeprecatedGlobalSettings::isAVFoundationEnabled())
> +	   return true;
> +#endif

The AVFoundation and CoreMedia frameworks are not installed on a recovery
partition, so this will cause HTMLMediaElement to be in the DOM but
MediaPlayerPrivateAVFoundationObjC::registerMediaEngine will fail so <audio>
and <video> elements won't work. You might make
MediaPlayerPrivateAVFoundationObjC::isAvailable() public and call it here
instead.


More information about the webkit-reviews mailing list