[webkit-reviews] review granted: [Bug 178674] [Web Animations] Add basic timing and target properties : [Attachment 324588] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 23 14:33:03 PDT 2017


Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 178674: [Web Animations] Add basic timing and target properties
https://bugs.webkit.org/show_bug.cgi?id=178674

Attachment 324588: Patch

https://bugs.webkit.org/attachment.cgi?id=324588&action=review




--- Comment #6 from Dean Jackson <dino at apple.com> ---
Comment on attachment 324588
  --> https://bugs.webkit.org/attachment.cgi?id=324588
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324588&action=review

> Source/WebCore/ChangeLog:18
> +	   Tests: webanimations/animation-effect-timing.html
> +		  webanimations/animation-effect.html
> +		  webanimations/animation-interface-effect-property.html
> +		  webanimations/animation-interface-start-time-property.html
> +		  webanimations/keyframe-effect-interface-timing-duration.html
> +		  webanimations/keyframe-effect.html

Please file a bug to move these to WPT.

> Source/WebCore/animation/AnimationEffect.h:44
> +    enum ClassType {

Use enum class.

Then you'll probably need AnimationEffect::Foo elsewhere.

> Source/WebCore/animation/WebAnimation.h:50
> +    std::optional<double> bindingsStartTime() const;
> +    void setBindingsStartTime(std::optional<double>);
> +    std::optional<MonotonicTime> startTime() const { return m_startTime; }
> +    void setStartTime(MonotonicTime& startTime) { m_startTime = startTime; }

You're fixing my bad advice here.


More information about the webkit-reviews mailing list