[webkit-reviews] review granted: [Bug 178680] Stop using _UIApplicationUsesLegacyUI() : [Attachment 324584] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 23 14:18:24 PDT 2017
mitz at webkit.org has granted Tim Horton <thorton at apple.com>'s request for
review:
Bug 178680: Stop using _UIApplicationUsesLegacyUI()
https://bugs.webkit.org/show_bug.cgi?id=178680
Attachment 324584: Patch
https://bugs.webkit.org/attachment.cgi?id=324584&action=review
--- Comment #2 from mitz at webkit.org ---
Comment on attachment 324584
--> https://bugs.webkit.org/attachment.cgi?id=324584
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=324584&action=review
> Source/WebKit/UIProcess/ios/forms/WKFormSelectPopover.mm:268
> + CGFloat initialFontSize = cell.textLabel.font.pointSize;
> + UIFont *font = cell.textLabel.font;
Flip the order and you can just initialize initialFontSize to font.pointSize.
> Source/WebKit/UIProcess/ios/forms/WKFormSelectPopover.mm:393
> + BOOL needsNavigationController = title.length;
!!title.length for targets where BOOL is a char.
More information about the webkit-reviews
mailing list