[webkit-reviews] review granted: [Bug 146692] Web Inspector: Please support HAR Export for network traffic : [Attachment 324538] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 23 13:54:46 PDT 2017


Brian Burg <bburg at apple.com> has granted Joseph Pecoraro <joepeck at webkit.org>'s
request for review:
Bug 146692: Web Inspector: Please support HAR Export for network traffic
https://bugs.webkit.org/show_bug.cgi?id=146692

Attachment 324538: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=324538&action=review




--- Comment #12 from Brian Burg <bburg at apple.com> ---
Comment on attachment 324538
  --> https://bugs.webkit.org/attachment.cgi?id=324538
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=324538&action=review

r=me

> LayoutTests/http/tests/inspector/network/har/har-basic-expected.txt:37
> +	   "title":
"http://127.0.0.1:8000/inspector/network/har/har-basic.html",

Is loopback hardcoded in other tests like this?

> LayoutTests/http/tests/inspector/network/har/har-basic.html:24
> +	       let har = await WI.HARBuilder.buildArchive([]);

Very interesting. I haven't read much async/await code.

> Source/WebInspectorUI/ChangeLog:63
> +	   Capture the raw, unmodified, base64 encoded and content. This ends
up

Nit: -and

> Source/WebInspectorUI/UserInterface/Controllers/HARBuilder.js:32
> +    static async buildArchive(resources)

I found it a little weird that this is a singleton and all static methods, but
I guess it needs to use a ton of other global state anyway.

> Source/WebInspectorUI/UserInterface/Controllers/HARBuilder.js:235
> +	   // FIXME: Implement HAR cache data.

Please file a bug for this.

> Source/WebInspectorUI/UserInterface/Controllers/HARBuilder.js:242
> +	   // NOTE: Chrome Custom Fields `_blocked_queueing` and
`_blocked_proxy`.

Weird grammar.

> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:1386
> +	   if (!resources.length) {

Maybe it would be more obvious when exporting is not possible, by making the
button become disabled when this condition is true.


More information about the webkit-reviews mailing list