[webkit-reviews] review granted: [Bug 178609] [Payment Request] Resolve PaymentRequest.show()'s accept promise when a payment is authorized : [Attachment 324468] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 23 09:49:00 PDT 2017


Alex Christensen <achristensen at apple.com> has granted Andy Estes
<aestes at apple.com>'s request for review:
Bug 178609: [Payment Request] Resolve PaymentRequest.show()'s accept promise
when a payment is authorized
https://bugs.webkit.org/show_bug.cgi?id=178609

Attachment 324468: Patch

https://bugs.webkit.org/attachment.cgi?id=324468&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 324468
  --> https://bugs.webkit.org/attachment.cgi?id=324468
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324468&action=review

> Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:287
> +    auto address = PaymentAddress::create();
> +    address->setCountry(contact.countryCode);

Could we make a constructor that takes these values so if we add one later we
won't forget to add setters in all the necessary places?

> Source/WebCore/Modules/paymentrequest/PaymentAddress.h:38
> +    static Ref<PaymentAddress> create()

Yeah, let's add a meaningful constructor instead of a bunch of setters.


More information about the webkit-reviews mailing list