[webkit-reviews] review granted: [Bug 178640] [iOS] WebProcess::initializeWebProcess spends ~150ms spinning up AVSystemController on some devices : [Attachment 324517] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 22 18:45:21 PDT 2017


youenn fablet <youennf at gmail.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 178640: [iOS] WebProcess::initializeWebProcess spends ~150ms spinning up
AVSystemController on some devices
https://bugs.webkit.org/show_bug.cgi?id=178640

Attachment 324517: Patch

https://bugs.webkit.org/attachment.cgi?id=324517&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 324517
  --> https://bugs.webkit.org/attachment.cgi?id=324517
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324517&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:3421
> +	   NSError *error = nil;

Is is usually style for mm file to do "NSError *error" in lieu of CPP like
"NSError* error"?


More information about the webkit-reviews mailing list