[webkit-reviews] review granted: [Bug 178647] [JSC][Baseline] Use linkAllSlowCasesForBytecodeOffset as much as possible to simplify slow cases handling : [Attachment 324530] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 22 11:02:47 PDT 2017


Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 178647: [JSC][Baseline] Use linkAllSlowCasesForBytecodeOffset as much as
possible to simplify slow cases handling
https://bugs.webkit.org/show_bug.cgi?id=178647

Attachment 324530: Patch

https://bugs.webkit.org/attachment.cgi?id=324530&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 324530
  --> https://bugs.webkit.org/attachment.cgi?id=324530
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324530&action=review

> Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp:976
> +    linkAllSlowCasesForBytecodeOffset(m_slowCases, iter, m_bytecodeOffset);

Every call to this passes m_slowCases and m_bytecodeOffset. Maybe it’s worth
making a wrapper function that just passes these values so all you need to pass
in is iter?


More information about the webkit-reviews mailing list