[webkit-reviews] review granted: [Bug 178619] createImageBitmap with basic HTMLImageElement : [Attachment 324497] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Oct 21 01:03:46 PDT 2017
Antoine Quint <graouts at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 178619: createImageBitmap with basic HTMLImageElement
https://bugs.webkit.org/show_bug.cgi?id=178619
Attachment 324497: Patch
https://bugs.webkit.org/attachment.cgi?id=324497&action=review
--- Comment #3 from Antoine Quint <graouts at apple.com> ---
Comment on attachment 324497
--> https://bugs.webkit.org/attachment.cgi?id=324497
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=324497&action=review
> Source/WebCore/html/ImageBitmap.cpp:133
> + // FIXME: Move this into a separate function and handle the
cropping/resizing.
Could use a bugzilla bug here.
> LayoutTests/http/wpt/common/canvas-tests.js:35
> +function _assertPixel(canvas, x,y, r,g,b,a, pos, colour)
I'm pretty sure it's "color"
More information about the webkit-reviews
mailing list