[webkit-reviews] review canceled: [Bug 178617] Web Inspector: Remove unused Console.setMonitoringXHREnabled : [Attachment 324493] [PATCH] Proposed Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Oct 21 00:02:07 PDT 2017
Joseph Pecoraro <joepeck at webkit.org> has canceled Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 178617: Web Inspector: Remove unused Console.setMonitoringXHREnabled
https://bugs.webkit.org/show_bug.cgi?id=178617
Attachment 324493: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=324493&action=review
--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 324493
--> https://bugs.webkit.org/attachment.cgi?id=324493
[PATCH] Proposed Fix
View in context: https://bugs.webkit.org/attachment.cgi?id=324493&action=review
> Source/JavaScriptCore/inspector/agents/JSGlobalObjectConsoleAgent.h:37
> JSGlobalObjectConsoleAgent(AgentContext&, InspectorHeapAgent*);
> virtual ~JSGlobalObjectConsoleAgent() { }
Actually I don't think this needs to be virtual anymore! Let me do a little
more cleanup.
More information about the webkit-reviews
mailing list