[webkit-reviews] review granted: [Bug 178614] Web Inspector: Support `async test() { ... }` in Inspector Test Suites : [Attachment 324486] [PATCH] Proposed Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 20 22:05:13 PDT 2017
Devin Rousso <webkit at devinrousso.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 178614: Web Inspector: Support `async test() { ... }` in Inspector Test
Suites
https://bugs.webkit.org/show_bug.cgi?id=178614
Attachment 324486: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=324486&action=review
--- Comment #4 from Devin Rousso <webkit at devinrousso.com> ---
Comment on attachment 324486
--> https://bugs.webkit.org/attachment.cgi?id=324486
[PATCH] Proposed Fix
View in context: https://bugs.webkit.org/attachment.cgi?id=324486&action=review
r=me. One typo. Also waiting on the tests to make sure it's all good :)
> LayoutTests/inspector/unit-tests/async-test-suite.html:445
> + description: "Check that an async suite with async test functions
that throws with a runtime erorr will reject",
Typo. "erorr" -> "error"
> Source/WebInspectorUI/UserInterface/Test/TestSuite.js:153
> + if (testcase.test.toString().startsWith("async "))
This feels hacky, but I'm not sure if there's any other way around it :|
More information about the webkit-reviews
mailing list