[webkit-reviews] review granted: [Bug 158938] Web Inspector: preview content view for MIME type application/json should be a collapsible tree outline : [Attachment 324484] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 20 21:36:13 PDT 2017


Brian Burg <bburg at apple.com> has granted Joseph Pecoraro <joepeck at webkit.org>'s
request for review:
Bug 158938: Web Inspector: preview content view for MIME type application/json
should be a collapsible tree outline
https://bugs.webkit.org/show_bug.cgi?id=158938

Attachment 324484: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=324484&action=review




--- Comment #15 from Brian Burg <bburg at apple.com> ---
Comment on attachment 324484
  --> https://bugs.webkit.org/attachment.cgi?id=324484
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=324484&action=review

r=me

Do we want JSON trees in the request as well, if they payload contains
JSON-like data? (This would be a followup patch)

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:509
> +localizedStrings["JSON"] = "JSON";

I don't think this is localizable.

> Source/WebInspectorUI/UserInterface/Views/JSONResourceContentView.js:47
> +	       JSON.parse(content);

This all seems rather duplicative, but I guess it's fine?


More information about the webkit-reviews mailing list