[webkit-reviews] review granted: [Bug 178584] Support ::before/::after pseudo elements with display:contents : [Attachment 324426] patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 178584: Support ::before/::after pseudo elements with display:contents
https://bugs.webkit.org/show_bug.cgi?id=178584

Attachment 324426: patch

https://bugs.webkit.org/attachment.cgi?id=324426&action=review




--- Comment #9 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 324426
  --> https://bugs.webkit.org/attachment.cgi?id=324426
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324426&action=review

> Source/WebCore/style/RenderTreeUpdaterGeneratedContent.cpp:117
> +	       removeAndDestroyContentRenderers(*pseudoElement);
> +

Could you clarify why this code change is needed in the change log?

> Source/WebCore/style/RenderTreeUpdaterGeneratedContent.cpp:156
> +	   if (pseudoElementRenderer)
> +	       renderTreePosition.moveToLastChild();
> +	   else
> +	       renderTreePosition.computeNextSibling(*pseudoElement);

Could you also describe why code to move to the next sibling is needed in the
change log?