[webkit-reviews] review granted: [Bug 178542] Generated serializers do not properly handle optional interface attributes : [Attachment 324412] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 20 10:22:16 PDT 2017


Sam Weinig <sam at webkit.org> has granted Andy Estes <aestes at apple.com>'s request
for review:
Bug 178542: Generated serializers do not properly handle optional interface
attributes
https://bugs.webkit.org/show_bug.cgi?id=178542

Attachment 324412: Patch

https://bugs.webkit.org/attachment.cgi?id=324412&action=review




--- Comment #5 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 324412
  --> https://bugs.webkit.org/attachment.cgi?id=324412
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324412&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:5260
> +		   push(@implContent, "       
ASSERT(!${name}Value.isUndefined());\n");

I don't think this is necessary.


More information about the webkit-reviews mailing list