[webkit-reviews] review granted: [Bug 178390] Support recursive tail call optimization for polymorphic calls : [Attachment 324401] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 20 10:05:48 PDT 2017


Saam Barati <sbarati at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 178390: Support recursive tail call optimization for polymorphic calls
https://bugs.webkit.org/show_bug.cgi?id=178390

Attachment 324401: Patch

https://bugs.webkit.org/attachment.cgi?id=324401&action=review




--- Comment #9 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 324401
  --> https://bugs.webkit.org/attachment.cgi?id=324401
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324401&action=review

r=me

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1739
> +    if (InlineCallFrame::isTail(kind) &&
ByteCodeParser::handleRecursiveTailCall(callee, registerOffset,
argumentCountIncludingThis, insertChecksWithAccounting)) {

I think you should check the kind == InlineCallFrame::TailCall here and not
InlineCallFrame::isTail since that returns true for varargs. Even if this is
never called with varargs, I think being explicit is more intuitive.

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1797
> +	   (void) c;

Why name this parameter if it's unused?


More information about the webkit-reviews mailing list