[webkit-reviews] review granted: [Bug 178568] Unify the node removal code in ContainerNode and expand the coverage of NoEventDispatchAssertion : [Attachment 324362] Cleanup
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 20 00:31:50 PDT 2017
Antti Koivisto <koivisto at iki.fi> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 178568: Unify the node removal code in ContainerNode and expand the
coverage of NoEventDispatchAssertion
https://bugs.webkit.org/show_bug.cgi?id=178568
Attachment 324362: Cleanup
https://bugs.webkit.org/attachment.cgi?id=324362&action=review
--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 324362
--> https://bugs.webkit.org/attachment.cgi?id=324362
Cleanup
View in context: https://bugs.webkit.org/attachment.cgi?id=324362&action=review
> Source/WebCore/dom/ContainerNode.cpp:103
> + NoEventDispatchAssertion assertNoEventDispatch;
Wish NoEventDispatchAssertion was a release assert
> Source/WebCore/dom/ContainerNode.cpp:784
> + // FIXME: Nodes inside a shadow tree should also retain its wrappers.
> + willCreatePossiblyOrphanedTreeByRemoval(child.ptr());
This call should also be somewhere else than dispatchChildRemovalEvents.
More information about the webkit-reviews
mailing list