[webkit-reviews] review granted: [Bug 178552] ServiceWorkerContextManager should be an IPC::MessageReceiver : [Attachment 324316] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 19 17:14:22 PDT 2017
youenn fablet <youennf at gmail.com> has granted review:
Bug 178552: ServiceWorkerContextManager should be an IPC::MessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=178552
Attachment 324316: Patch
https://bugs.webkit.org/attachment.cgi?id=324316&action=review
--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 324316
--> https://bugs.webkit.org/attachment.cgi?id=324316
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=324316&action=review
> Source/WebKit/WebProcess/Storage/ServiceWorkerContextManager.messages.in:27
> + StartFetchInServiceWorker(uint64_t serverConnectionIdentifier, uint64_t
fetchIdentifier, uint64_t serviceWorkerIdentifier, WebCore::ResourceRequest
request, struct WebCore::FetchOptions options)
Can we rename these to StartWorker and Fetch since they are now scoped by
ServiceWorkerContextManager?
> Source/WebKit/WebProcess/WebProcess.cpp:665
>
#if ENABLE(SERVICE_WORKER) probably
> Source/WebKit/WebProcess/WebProcess.cpp:667
> + if (m_serviceWorkerManager)
Can you add ASSERT(m_serviceWorkerManager);
More information about the webkit-reviews
mailing list