[webkit-reviews] review granted: [Bug 177473] WebAssembly: no VM / JS version of everything but Instance : [Attachment 324306] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 19 16:05:49 PDT 2017
Saam Barati <sbarati at apple.com> has granted JF Bastien <jfbastien at apple.com>'s
request for review:
Bug 177473: WebAssembly: no VM / JS version of everything but Instance
https://bugs.webkit.org/show_bug.cgi?id=177473
Attachment 324306: patch
https://bugs.webkit.org/attachment.cgi?id=324306&action=review
--- Comment #42 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 324306
--> https://bugs.webkit.org/attachment.cgi?id=324306
patch
View in context: https://bugs.webkit.org/attachment.cgi?id=324306&action=review
r=me too
> Source/WTF/wtf/StdLibExtras.h:167
> +template<typename T>
> +inline T& default_construct_at(T* addr)
> +{
> + return *new (addr) T();
> +}
I'd vote for removing this since nobody seemed to like it in the other patch
you opened.
More information about the webkit-reviews
mailing list