[webkit-reviews] review requested: [Bug 177473] WebAssembly: no VM / JS version of everything but Instance : [Attachment 324306] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 19 15:48:10 PDT 2017
JF Bastien <jfbastien at apple.com> has asked for review:
Bug 177473: WebAssembly: no VM / JS version of everything but Instance
https://bugs.webkit.org/show_bug.cgi?id=177473
Attachment 324306: patch
https://bugs.webkit.org/attachment.cgi?id=324306&action=review
--- Comment #38 from JF Bastien <jfbastien at apple.com> ---
Created attachment 324306
--> https://bugs.webkit.org/attachment.cgi?id=324306&action=review
patch
Fix the bug that caused a revert: moving the wasm->JS entries to the
Wasm::CodeBlock (from the JSWebAssemblyCodeBlock) was invalid because they have
the address of the VM baked into them. They're now on the JSWebAssemblyInstance
instead.
More information about the webkit-reviews
mailing list