[webkit-reviews] review granted: [Bug 178533] [Bindings] Standardize on DOMPromise as the way to store passed in promises : [Attachment 324297] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 19 15:44:46 PDT 2017


youenn fablet <youennf at gmail.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 178533: [Bindings] Standardize on DOMPromise as the way to store passed in
promises
https://bugs.webkit.org/show_bug.cgi?id=178533

Attachment 324297: Patch

https://bugs.webkit.org/attachment.cgi?id=324297&action=review




--- Comment #7 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 324297
  --> https://bugs.webkit.org/attachment.cgi?id=324297
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324297&action=review

> Source/WebCore/Modules/paymentrequest/PaymentRequestUpdateEvent.cpp:37
> +void PaymentRequestUpdateEvent::updateWith(RefPtr<DOMPromise>&&)

Ref<>?

> Source/WebCore/dom/PromiseRejectionEvent.h:38
> +	   RefPtr<DOMPromise> promise;

It should probably be a Ref<DOMPromise> as promise is required.

> Source/WebCore/workers/service/FetchEvent.cpp:138
> +	   [] (Ref<FormData>&) {

Indentation like for regular switch?


More information about the webkit-reviews mailing list