[webkit-reviews] review granted: [Bug 178538] [FrameView::layout cleanup] Move post layout task scheduling logic to a separate function : [Attachment 324277] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 19 14:06:31 PDT 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 178538: [FrameView::layout cleanup] Move post layout task scheduling logic
to a separate function
https://bugs.webkit.org/show_bug.cgi?id=178538

Attachment 324277: Patch

https://bugs.webkit.org/attachment.cgi?id=324277&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 324277
  --> https://bugs.webkit.org/attachment.cgi?id=324277
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324277&action=review

> Source/WebCore/page/FrameView.cpp:1568
> +    // If we are already in a synchronous call, defer post layout tasks
until after we return.

blank line above.

> Source/WebCore/page/FrameView.cpp:1569
> +    // Post layout taks can make us need to update again, and we can get
stuck in a cycle.

The following call to performPostLayoutTasks can cause this function to get
re-entered. We use the timer to prevent re-entrancy.

> Source/WebCore/page/FrameView.cpp:1574
> +    performPostLayoutTasks();

blank line above

> Source/WebCore/page/FrameView.cpp:1576
> +	   // Post layout widget tasks made us need layout again.

Remove this line.

> Source/WebCore/page/FrameView.h:692
>      void performPostLayoutTasks();
> +    void runOrSchedulePostLayoutTasks();

Maybe swap.


More information about the webkit-reviews mailing list