[webkit-reviews] review granted: [Bug 178527] Service Worker process should not be selected to open WebView on it : [Attachment 324256] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 19 12:21:52 PDT 2017


Chris Dumez <cdumez at apple.com> has granted  review:
Bug 178527: Service Worker process should not be selected to open WebView on it
https://bugs.webkit.org/show_bug.cgi?id=178527

Attachment 324256: Patch

https://bugs.webkit.org/attachment.cgi?id=324256&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 324256
  --> https://bugs.webkit.org/attachment.cgi?id=324256
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324256&action=review

r=me with comments.

> Source/WebKit/UIProcess/WebProcessPool.cpp:940
> +    Vector<std::reference_wrapper<WebProcessProxy>> processes;

I think processes is too generic, how about reusableProcesses ?

> Source/WebKit/UIProcess/WebProcessPool.cpp:944
> +	   if (isMatchingStore && (process.get() != m_workerContextProcess))

You're going to need to protect the second check behind a #if
ENABLE(SERVICE_WORKER)


More information about the webkit-reviews mailing list