[webkit-reviews] review granted: [Bug 178512] [Settings] Move global settings into their own file : [Attachment 324230] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 19 09:20:34 PDT 2017
Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 178512: [Settings] Move global settings into their own file
https://bugs.webkit.org/show_bug.cgi?id=178512
Attachment 324230: Patch
https://bugs.webkit.org/attachment.cgi?id=324230&action=review
--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 324230
--> https://bugs.webkit.org/attachment.cgi?id=324230
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=324230&action=review
> Source/WebCore/ChangeLog:10
> + like to discourage, as WebCore can operate in a process with
mulitple clients, each of
typo: multiple
> Source/WebCore/html/HTMLMediaElement.cpp:6822
> + return DeprecatedGlobalSettings::networkInterfaceName();
Looks like iOS build is failing because this file is missing an include of
DeprecatedGlobalSettings.h.
> Source/WebCore/page/DeprecatedGlobalSettings.h:33
> +class DeprecatedGlobalSettings {
I think it would be good to delete the constructor.
More information about the webkit-reviews
mailing list