[webkit-reviews] review granted: [Bug 178494] http/tests/workers/service/basic-register.html is a flaky failure. : [Attachment 324203] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 19 08:25:54 PDT 2017


youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 178494: http/tests/workers/service/basic-register.html is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=178494

Attachment 324203: Patch

https://bugs.webkit.org/attachment.cgi?id=324203&action=review




--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 324203
  --> https://bugs.webkit.org/attachment.cgi?id=324203
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324203&action=review

> Source/WebKit/StorageProcess/ServiceWorker/WebSWOriginStore.cpp:47
> +    m_store.flushPendingChanges();

scheduleAddition will add to the pending list and will start the timer.
Then flushPendingChanges will stop the timer and process the operations.
Is there a way to simplify this?

> Source/WebKit/StorageProcess/ServiceWorker/WebSWOriginStore.cpp:50
> +void WebSWOriginStore::addAll(const Vector<SecurityOrigin>& origins)

addAll is not used AFAICT.
If we keep it and have a removeAll, is there still a need for the timer?


More information about the webkit-reviews mailing list