[webkit-reviews] review granted: [Bug 178340] [JSC] ScriptFetcher should be notified directly from module pipeline : [Attachment 324224] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 19 07:53:06 PDT 2017


Sam Weinig <sam at webkit.org> has granted Yusuke Suzuki <utatane.tea at gmail.com>'s
request for review:
Bug 178340: [JSC] ScriptFetcher should be notified directly from module
pipeline
https://bugs.webkit.org/show_bug.cgi?id=178340

Attachment 324224: Patch

https://bugs.webkit.org/attachment.cgi?id=324224&action=review




--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 324224
  --> https://bugs.webkit.org/attachment.cgi?id=324224
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324224&action=review

> Source/JavaScriptCore/runtime/JSModuleLoader.cpp:312
> +    Identifier moduleKey = jsValueToModuleKey(exec, key);

could use auto here.


More information about the webkit-reviews mailing list