[webkit-reviews] review granted: [Bug 178503] [FrameView::layout cleanup] Replace m_nestedLayoutCount with isLayoutNested() : [Attachment 324206] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 19 02:39:05 PDT 2017


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 178503: [FrameView::layout cleanup] Replace m_nestedLayoutCount with
isLayoutNested()
https://bugs.webkit.org/show_bug.cgi?id=178503

Attachment 324206: Patch

https://bugs.webkit.org/attachment.cgi?id=324206&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 324206
  --> https://bugs.webkit.org/attachment.cgi?id=324206
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324206&action=review

> Source/WebCore/page/FrameView.h:811
> +    enum class LayoutNestedState { Invalid, NotNested, Nested };
> +    LayoutNestedState m_layoutNestedState { LayoutNestedState::Invalid };

Maybe NotInLayout instead if Invalid?

Wonder if we could some some sort of LayoutContext struct that would contain
stuff that only makes sense during layout.


More information about the webkit-reviews mailing list