[webkit-reviews] review granted: [Bug 177766] [Settings] Convert more settings to be generated : [Attachment 324191] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 18 20:41:25 PDT 2017
Dean Jackson <dino at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 177766: [Settings] Convert more settings to be generated
https://bugs.webkit.org/show_bug.cgi?id=177766
Attachment 324191: Patch
https://bugs.webkit.org/attachment.cgi?id=324191&action=review
--- Comment #10 from Dean Jackson <dino at apple.com> ---
Comment on attachment 324191
--> https://bugs.webkit.org/attachment.cgi?id=324191
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=324191&action=review
> Source/WebCore/page/Settings.in:328
> +loadsImagesAutomatically initial=false, onChange=imagesEnabledChanged
> +imagesEnabled initial=true, getter=areImagesEnabled,
onChange=imagesEnabledChanged
Should these have the same onChange?
Answer: yes, even though it looks like a typo.
> Source/WebCore/page/SettingsBase.cpp:478
>
> +
> +
Lots of spaces
More information about the webkit-reviews
mailing list