[webkit-reviews] review granted: [Bug 178496] [FrameView::layout cleanup] Group related pre-layout code to improve readability : [Attachment 324193] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 18 18:44:31 PDT 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 178496: [FrameView::layout cleanup] Group related pre-layout code to
improve readability
https://bugs.webkit.org/show_bug.cgi?id=178496

Attachment 324193: Patch

https://bugs.webkit.org/attachment.cgi?id=324193&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 324193
  --> https://bugs.webkit.org/attachment.cgi?id=324193
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324193&action=review

> Source/WebCore/page/FrameView.cpp:1360
> +    // we shouldn't enter layout() while painting

Sentence case please.

> Source/WebCore/page/FrameView.cpp:1363
> +	   LOG(Layout, "  in  is disallowed, bailing");

Please change the message to distinguish this from the case above. This should
say "in painting is".


More information about the webkit-reviews mailing list