[webkit-reviews] review granted: [Bug 178481] webkitpy tests should have --json-output option : [Attachment 324152] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 18 13:00:06 PDT 2017
Alexey Proskuryakov <ap at webkit.org> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 178481: webkitpy tests should have --json-output option
https://bugs.webkit.org/show_bug.cgi?id=178481
Attachment 324152: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=324152&action=review
--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 324152
--> https://bugs.webkit.org/attachment.cgi?id=324152
Proposed patch
View in context: https://bugs.webkit.org/attachment.cgi?id=324152&action=review
> Tools/Scripts/webkitpy/test/main.py:123
> parser.add_option('--json', action='store_true', default=False,
> help='write JSON formatted test results to
stdout')
> + parser.add_option('--json-output', action='store', type='string',
dest='json_file_name',
> + help='Create a file at specified path, listing
test results in JSON format.')
I think that we need at least a fixme to clean this up. Standard output is just
a kind of file, so having two options is unnecessary and highly unusual.
Better yet, mark the old one as deprecated, and better yet, remove it.
More information about the webkit-reviews
mailing list