[webkit-reviews] review granted: [Bug 178479] [FrameView::layout cleanup] Use SetForScope to protect m_needsFullRepaint's value on reentrancy : [Attachment 324144] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 18 12:55:26 PDT 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 178479: [FrameView::layout cleanup] Use SetForScope to protect
m_needsFullRepaint's value on reentrancy
https://bugs.webkit.org/show_bug.cgi?id=178479

Attachment 324144: Patch

https://bugs.webkit.org/attachment.cgi?id=324144&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 324144
  --> https://bugs.webkit.org/attachment.cgi?id=324144
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324144&action=review

> Source/WebCore/page/FrameView.cpp:1527
> +	   SetForScope<bool> needsFullRepaint(m_needsFullRepaint);
> +	   if (!isSubtreeLayout &&
!downcast<RenderView>(*layoutRoot).printing()) {

Can't you just move the scope inside the if () condition, rather than adding an
extra set of braces?


More information about the webkit-reviews mailing list