[webkit-reviews] review granted: [Bug 177585] Overlapping text on all CSS fonts specs : [Attachment 324114] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 18 10:05:30 PDT 2017


Daniel Bates <dbates at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 177585: Overlapping text on all CSS fonts specs
https://bugs.webkit.org/show_bug.cgi?id=177585

Attachment 324114: patch

https://bugs.webkit.org/attachment.cgi?id=324114&action=review




--- Comment #10 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 324114
  --> https://bugs.webkit.org/attachment.cgi?id=324114
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324114&action=review

> LayoutTests/fast/html/details-line-height-overlap-expected.html:1
> +<html>

Is it necessary to use quirks mode to render this file? Also, the markup in
this document is not well-formed. Is this intentional? If we do not need quirks
mode then please add <!DOCTYPE html>.

> LayoutTests/fast/html/details-line-height-overlap.html:1
> +<html>

Ditto.


More information about the webkit-reviews mailing list