[webkit-reviews] review granted: [Bug 178462] [Settings] Miscellaneous cleanup of the settings generation scripts : [Attachment 324121] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 18 10:00:43 PDT 2017


Daniel Bates <dbates at webkit.org> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 178462: [Settings] Miscellaneous cleanup of the settings generation scripts
https://bugs.webkit.org/show_bug.cgi?id=178462

Attachment 324121: Patch

https://bugs.webkit.org/attachment.cgi?id=324121&action=review




--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 324121
  --> https://bugs.webkit.org/attachment.cgi?id=324121
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324121&action=review

> Source/WebCore/ChangeLog:9
> +	   - Make functions operating on the python Setting object member
functions

python => Python

> Source/WebCore/Scripts/GenerateSettings/Settings.py:82
> +	   if self.setNeedsStyleRecalcInAllFrames:
> +	       return True
> +	   return False

return self.setNeedsStyleRecalcInAllFrames

> Source/WebCore/Scripts/GenerateSettings/Settings.py:87
> +	   if self.type == 'String':
> +	       return False
> +	   return True

return self.type != 'String'

> Source/WebCore/Scripts/GenerateSettings/Settings.py:90
> +	   for prefix in ["css", "xss", "ftp", "dom"]:

" => '

> Source/WebCore/Scripts/GenerateSettings/Settings.py:92
> +		   return "set" + uppercaseFirstN(self.name, len(prefix))

Ditto.

> Source/WebCore/Scripts/GenerateSettings/Settings.py:93
> +	   return "set" + uppercaseFirstN(self.name, 1)

Ditto.


More information about the webkit-reviews mailing list