[webkit-reviews] review granted: [Bug 178201] Replace some stack raw pointers with RefPtrs within WebCore/html : [Attachment 324084] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Jiewen Tan <jiewen_tan at apple.com>'s
request for review:
Bug 178201: Replace some stack raw pointers with RefPtrs within WebCore/html
https://bugs.webkit.org/show_bug.cgi?id=178201

Attachment 324084: Patch

https://bugs.webkit.org/attachment.cgi?id=324084&action=review




--- Comment #47 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 324084
  --> https://bugs.webkit.org/attachment.cgi?id=324084
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324084&action=review

> Source/WebCore/html/InputType.h:219
> -    virtual TextControlInnerTextElement* innerTextElement() const { return
nullptr; }
> +    virtual RefPtr<TextControlInnerTextElement> innerTextElement() const {
return nullptr; }

Please move this implementation to the InputType.cpp instead of including
TextControlInnerElements.h since this is a virtual function.