[webkit-reviews] review denied: [Bug 178415] [Win] Null pointer crash under AutoscrollController::stopAutoscrollTimer. : [Attachment 324068] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 17 17:00:27 PDT 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 178415: [Win] Null pointer crash under
AutoscrollController::stopAutoscrollTimer.
https://bugs.webkit.org/show_bug.cgi?id=178415

Attachment 324068: Patch

https://bugs.webkit.org/attachment.cgi?id=324068&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 324068
  --> https://bugs.webkit.org/attachment.cgi?id=324068
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324068&action=review

> Source/WebCore/page/AutoscrollController.cpp:96
> +    if (!scrollable || !scrollable->document().frame())
>	   return;
>  
>      Frame& frame = scrollable->frame();

This is weird. If we can get a Frame& from a non-null scrollable, then it's
bizarre to check scrollable->document().frame() first.


More information about the webkit-reviews mailing list