[webkit-reviews] review granted: [Bug 178414] [FrameView::layout cleanup] Remove redundant body->renderer()->setChildNeedsLayout call : [Attachment 324067] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 17 16:45:51 PDT 2017
Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 178414: [FrameView::layout cleanup] Remove redundant
body->renderer()->setChildNeedsLayout call
https://bugs.webkit.org/show_bug.cgi?id=178414
Attachment 324067: Patch
https://bugs.webkit.org/attachment.cgi?id=324067&action=review
--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 324067
--> https://bugs.webkit.org/attachment.cgi?id=324067
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=324067&action=review
> Source/WebCore/page/FrameView.cpp:-1444
> - if (!m_firstLayout && m_size.height() != layoutHeight()
&& body->renderer()->enclosingBox().stretchesToViewport())
> - body->renderer()->setChildNeedsLayout();
Does something else take care of the stretchesToViewport() case?
More information about the webkit-reviews
mailing list