[webkit-reviews] review requested: [Bug 178302] Web Inspector: Canvas2D Profiling: highlight expensive context commands in the captured command log : [Attachment 324056] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 17 14:26:00 PDT 2017
Devin Rousso <webkit at devinrousso.com> has asked for review:
Bug 178302: Web Inspector: Canvas2D Profiling: highlight expensive context
commands in the captured command log
https://bugs.webkit.org/show_bug.cgi?id=178302
Attachment 324056: Patch
https://bugs.webkit.org/attachment.cgi?id=324056&action=review
--- Comment #2 from Devin Rousso <webkit at devinrousso.com> ---
Created attachment 324056
--> https://bugs.webkit.org/attachment.cgi?id=324056&action=review
Patch
We currently don\'t have a way to capture the time taken in WebCore for each
recording action as CallTracer is only called right before the action is
performed. Due to this limitation, I have elected to calculate the time in the
frontend by using `performance.now()`. If we decide to move this timing to
WebCore, we would need to modify the bingings generator to support an
additional CallTracer function that is called right after the action is
performed.
More information about the webkit-reviews
mailing list