[webkit-reviews] review granted: [Bug 178361] [Settings] Generate Settings.h/cpp : [Attachment 324018] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 17 13:35:43 PDT 2017


Dean Jackson <dino at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 178361: [Settings] Generate Settings.h/cpp
https://bugs.webkit.org/show_bug.cgi?id=178361

Attachment 324018: Patch

https://bugs.webkit.org/attachment.cgi?id=324018&action=review




--- Comment #8 from Dean Jackson <dino at apple.com> ---
Comment on attachment 324018
  --> https://bugs.webkit.org/attachment.cgi?id=324018
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324018&action=review

> Source/WebCore/Scripts/GenerateSettings/GenerateSettingsHeaderFile.py:31
> +
> +
> +def generateSettingsHeaderFile(outputDirectory, settings):

Nit: Too/two many blank lines.

> Source/WebCore/Scripts/GenerateSettings/GenerateSettingsHeaderFile.py:43
> +    outputFile.write("#pragma once\n\n")
> +
> +    outputFile.write("#include \"SettingsBase.h\"\n")
> +    outputFile.write("#include \"SettingsMacros.h\"\n")
> +    outputFile.write("#include <wtf/RefCounted.h>\n\n")
> +
> +    outputFile.write("namespace WebCore {\n\n")
> +

All this stuff might work better as a """ string, to avoid multiple write
lines. But no biggy.


More information about the webkit-reviews mailing list