[webkit-reviews] review granted: [Bug 178402] webkitpy: Hang when workers write to the same stack trace file : [Attachment 324035] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 17 12:14:12 PDT 2017


Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 178402: webkitpy: Hang when workers write to the same stack trace file
https://bugs.webkit.org/show_bug.cgi?id=178402

Attachment 324035: Patch

https://bugs.webkit.org/attachment.cgi?id=324035&action=review




--- Comment #4 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 324035
  --> https://bugs.webkit.org/attachment.cgi?id=324035
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324035&action=review

> Tools/Scripts/webkitpy/common/interupt_debugging.py:47
> +	   file_name = os.path.join(os.path.dirname(output_file),
'{}-{}'.format(os.getpid(), os.path.basename(output_file))) if output_file else
None

Is it guaranteed that we won't have file name collision after adding
os.getpid() ?
Maybe we can add timestamp in filename instead of pid to make it unique, it
would also make it easy to sort these files into the directory having multiple
such files.


More information about the webkit-reviews mailing list